Skip to content

gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst #143182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
duane9 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst #143182

duane9 wants to merge 2 commits into from
+4 −4

Conversation

@duane9
Copy link

@duane9 duane9 commented Dec 26, 2025 •
edited by terryjreedy
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 26, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Dec 26, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Dec 26, 2025
@bedevere-app bedevere-app bot mentioned this pull request Dec 26, 2025
Open
@hugovk
Copy link
Member

hugovk commented Dec 26, 2025

There's some "overriden" in test comments, want to fix them too?

Also, no need to create an issue next time for trivial things like typo fixes.

https://devguide.python.org/getting-started/pull-request-lifecycle/#id2

StanFromIreland
StanFromIreland approved these changes Dec 26, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev skirpichev mentioned this pull request Dec 26, 2025
Closed
@terryjreedy terryjreedy changed the title gh-143181: Fix typo 'overriden' -> 'overridden' in c-api/module.rst gh-143181: Fix 'overriden' -> 'overridden' in c-api/module.rst Dec 26, 2025
@terryjreedy
Copy link
Member

terryjreedy commented Dec 26, 2025 

Searching 'overriden' in C:\Programs\Python315\Lib\test\*.py ...
C:\Programs\Python315\Lib\test\test_build_details.py: 36:         """Install details file contents. Should be overriden by subclasses."""
C:\Programs\Python315\Lib\test\test_dict.py: 1584:         # Only TypeError exception is overriden,
C:\Programs\Python315\Lib\test\test_set.py: 664:         # Only TypeError exception is overriden,

Need case-sensitive search to no match OverrideN....
Same in 3.14, not in 3.13. Likely new errors since last general spell check.

@duane9 duane9 requested a review from FFY00 as a code owner December 26, 2025 22:34
@StanFromIreland
Copy link
Member

StanFromIreland commented Dec 26, 2025 •
edited
Loading

Terry, here is a case-insensitive grep:

$ git grep -ri overriden
Doc/c-api/module.rst:  hook returned (unless overriden with :c:macro:`Py_mod_token`).
Lib/test/test_build_details.py:        """Install details file contents. Should be overriden by subclasses."""
Lib/test/test_descr.py:        class OverrideNeither:
Lib/test/test_descr.py:        self.assertRaises(TypeError, OverrideNeither, 1)
Lib/test/test_descr.py:        self.assertRaises(TypeError, OverrideNeither, kw=1)
Lib/test/test_descr.py:        class OverrideNew:
Lib/test/test_descr.py:        class OverrideBoth(OverrideNew, OverrideInit):
Lib/test/test_descr.py:        for case in OverrideNew, OverrideInit, OverrideBoth:
Lib/test/test_dict.py:        # Only TypeError exception is overriden,
Lib/test/test_set.py:        # Only TypeError exception is overriden,

@duane9 duane9 force-pushed the fix-overridden-typo branch from a7063df to 8b4c5ef Compare December 26, 2025 22:37
@duane9
Copy link
Author

duane9 commented Dec 26, 2025

Changed "overriden" -> "overridden" in the tests. Class names like OverrideNew and OverrideNeither were already spelled correctly with "Override", so they didn't need changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@duane9 @hugovk @terryjreedy @StanFromIreland @skirpichev